Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SVR4 support #153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add SVR4 support #153

wants to merge 1 commit into from

Conversation

papadave66
Copy link

No description provided.

@dcreager
Copy link
Owner

This is great, thank you! Have you verified that this causes the subprocess functions to work on those platforms? We unfortunately don't currently have any CI that could automatically test that. 🙁

Also, how would you like to be credited in the AUTHORS file?

@papadave66
Copy link
Author

papadave66 commented May 31, 2019

@Low-power and I have tested it on Oracle Solaris and openindiana. And they works fine. But cygwin still need to test later.

include/libcork/config/solaris.h Outdated Show resolved Hide resolved
@dcreager
Copy link
Owner

@Low-power and I have tested it on Oracle Solaris and openindiana. And they works fine. But cygwin still need to test later.

Sounds good. If there are any cygwin failures we can address them then.

@papadave66 papadave66 changed the title add SVR4 and cygwin support add SVR4 support Jun 1, 2019
@papadave66
Copy link
Author

I am going to support Cygwin in a separate pull-request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants