-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate bgp_instance framework to Plugin Framework #188
migrate bgp_instance framework to Plugin Framework #188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment about the docs change.
Also it looks like this error assertion is different when it's using the plugin framework
ExpectError: regexp.MustCompile(`Your RouterOS version does not support`), |
=== CONT TestAccMikrotikBgpInstance_createFailsOnRouterOSv7
resource_bgp_instance_test.go:50: Step 1/1, expected an error with pattern, no match on: Error running apply: exit status 1
Error: Creation failed
with mikrotik_bgp_instance.bar,
on terraform_plugin_test.tf line 2, in resource "mikrotik_bgp_instance" "bar":
2: resource "mikrotik_bgp_instance" "bar" {
from RouterOS device: no such command prefix
--- FAIL: TestAccMikrotikBgpInstance_createFailsOnRouterOSv7 (0.46s)
yes, it is not covered by current interface-based implementation of the client (will try to add support for that asap) |
No description provided.