Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/resource firewall filter #202

Conversation

maksym-nazarenko
Copy link
Collaborator

No description provided.

Copy link
Owner

@ddelnano ddelnano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting to see the final legacy resources migrated to the plugin framework! Thanks for moving so quickly through these and all the great scaffolding work that made this transition easier.

@maksym-nazarenko
Copy link
Collaborator Author

I'm really enjoying contributing to this project ;)

@maksym-nazarenko maksym-nazarenko merged commit e26b6a1 into ddelnano:master Sep 20, 2023
4 checks passed
@maksym-nazarenko maksym-nazarenko deleted the refactor/resource-firewall_filter branch September 20, 2023 06:12
@teadur
Copy link

teadur commented Nov 1, 2023

kube-clouds fork seems to have way fancier firewall, maybe the option set could be migrated to this provider ?
https://github.com/kube-cloud/terraform-provider-mikrotik/blob/master/client/firewall_rule.go
Do i understand correctly that neither of them support ipv6 ?

@maksym-nazarenko
Copy link
Collaborator Author

@teadur the resources were created with minimal option set in mind, as complete support requires much more work.
If you think there are missing parts, which could help you, feel free to create an issue with such request - I'll be glad to evaluate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants