Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: biggest crop area after rotation with aspect ratio #19

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • crop_controller.dart: specific case for rotation, where we go to the biggest centered crop area if aspect ratio is specified
  • main.dart: added a 1:2 aspect ratio, for tests

Impacted files:
* `crop_controller.dart`: specific case for rotation, where we go to the biggest centered crop area if aspect ratio is specified
* `main.dart`: added a `1:2` aspect ratio, for tests
@deakjahn deakjahn merged commit e1c2d1e into deakjahn:master Mar 8, 2023
@deakjahn
Copy link
Owner

deakjahn commented Mar 8, 2023

I published it (with a slightly amusing commit message typo :-) ), thanks for the solution and the effort.

@monsieurtanuki
Copy link
Contributor Author

You're welcome!
Good to see too that now the score is 140 points!
Can't remember: shouldn't it be a breaking change, like version 2.0.0?
And the demo video could be refreshed too, if you have time.
Couldn't detect the typo ;)

@deakjahn
Copy link
Owner

deakjahn commented Mar 8, 2023

"Bum up" instead of "bump up".

Well, I can no longer remember what I created the demo with. :-)

@deakjahn
Copy link
Owner

deakjahn commented Mar 8, 2023

Well, the video itself was obvious, in the emulator, but I used the first online converter I could find now (probably did the same last time around). It's a bit larger now, too.

@deakjahn
Copy link
Owner

deakjahn commented Mar 8, 2023

No, certainly not breaking as far as I can remember, just added functionality. But I'll add it to the README now, I should've thought of it earlier. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants