Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): non-minified outputs and better handling of strict mode #175

Merged
merged 6 commits into from
Jun 2, 2021
Merged

fix(build): non-minified outputs and better handling of strict mode #175

merged 6 commits into from
Jun 2, 2021

Conversation

mirceanis
Copy link
Member

@mirceanis mirceanis commented May 21, 2021 •
edited
Loading

What's here

@mirceanis mirceanis mentioned this pull request May 26, 2021
Closed
@mirceanis mirceanis requested a review from awoie May 31, 2021 12:39
awoie
awoie suggested changes May 31, 2021
View reviewed changes
Copy link
Member

@awoie awoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a few things.

package.json Outdated Show resolved Hide resolved
src/JWE.ts Outdated Show resolved Hide resolved
src/JWT.ts Outdated Show resolved Hide resolved
@mirceanis mirceanis requested review from awoie and jasheal June 1, 2021 08:53
jasheal
jasheal approved these changes Jun 2, 2021
View reviewed changes
Copy link

@jasheal jasheal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mirceanis mirceanis mentioned this pull request Jun 2, 2021
Closed
@mirceanis mirceanis merged commit 029b429 into master Jun 2, 2021
@mirceanis mirceanis deleted the support/build-outputs branch June 2, 2021 10:44
uport-automation-bot pushed a commit that referenced this pull request Jun 2, 2021
@semantic-release-bot
chore(release): 5.5.1 [skip ci]
9bea758 
## [5.5.1](5.5.0...5.5.1) (2021-06-02)

### Bug Fixes

* **build:** non-minified outputs and better handling of strict mode ([#175](#175)) ([029b429](029b429)), closes [#173](#173) [#174](#174)
* **ci:** add GH push ability to build bot ([e50edf6](e50edf6))
@uport-automation-bot
Copy link
Collaborator

🎉 This PR is included in version 5.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasheal jasheal jasheal approved these changes

@awoie awoie Awaiting requested review from awoie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@mirceanis @uport-automation-bot @jasheal @awoie