feat: add experimental support for ServiceEndpoint JSON #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirceanis
approved these changes
Aug 3, 2022
| @@ -217,10 +217,16 @@ export class EthrDidResolver { | |||
| } | |||
| case 'svc': | |||
| serviceCount++ | |||
| let endpoint | |||
| try { | |||
| endpoint = JSON.parse(Buffer.from(currentEvent.value.slice(2), 'hex').toString()) | |||
There was a problem hiding this comment.
While this works, it isn't a good reference implementation.
I think a better approach is to be specific about what is being added, and specifying an encoding.
So, instead of saying did/svc/<service name>, one would say did/svc/<serviceName>/j
Or something along these lines.
We need a small adjustment to the spec to make this happen, so I'll approve this as an experimental feature for now.
There was a problem hiding this comment.
in your example the j stands for json?
There was a problem hiding this comment.
Yes, it does.
But it's just an example.
See also #110
mirceanis
changed the title
uport-automation-bot
pushed a commit
that referenced
this pull request
Aug 4, 2022
# [6.1.0](6.0.2...6.1.0) (2022-08-04) ### Features * add experimental support for ServiceEndpoint objects ([#163](#163)) ([3919a25](3919a25))
|
🎉 This PR is included in version 6.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.