Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] input property key should be case-insensitive #1264

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

frankfliu
Copy link
Contributor

Change-Id: I9bcb5aab336f553f979b58523051af75ea134d90

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2021

Codecov Report

Merging #1264 (6f37fb8) into master (64e4b1b) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1264      +/-   ##
============================================
- Coverage     71.99%   71.98%   -0.01%     
  Complexity     5113     5113              
============================================
  Files           473      473              
  Lines         21909    21913       +4     
  Branches       2345     2345              
============================================
+ Hits          15774    15775       +1     
- Misses         4932     4933       +1     
- Partials       1203     1205       +2     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/inference/Predictor.java 91.34% <ø> (ø)
api/src/main/java/ai/djl/modality/Input.java 91.30% <66.66%> (-4.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64e4b1b...6f37fb8. Read the comment docs.

Change-Id: I9bcb5aab336f553f979b58523051af75ea134d90
@frankfliu frankfliu merged commit b0850da into deepjavalibrary:master Oct 4, 2021
@frankfliu frankfliu deleted the input branch October 4, 2021 20:21
maaquib pushed a commit to maaquib/djl that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants