fix: type of temperature param and adjust defaults for `OpenAIAnswe…

…rGenerator` (#3073) * fix: type of temperature param and adjust defaults * update schema * update api docs
deepset-ai · Sep 16, 2022 · 3134b0d · 3134b0d
1 parent 4ddeb7b
commit 3134b0d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/docs/_src/api/api/generator.md b/docs/_src/api/api/generator.md
@@ -370,9 +370,9 @@ on the [OpenAI API website](https://openai.com/api/).
 ```python
 def __init__(api_key: str,
              model: str = "text-curie-001",
-             max_tokens: int = 7,
+             max_tokens: int = 13,
              top_k: int = 5,
-             temperature: int = 0,
+             temperature: float = 0.2,
              presence_penalty: float = -2.0,
              frequency_penalty: float = -2.0,
              examples_context: Optional[str] = None,

diff --git a/haystack/json-schemas/haystack-pipeline-main.schema.json b/haystack/json-schemas/haystack-pipeline-main.schema.json
@@ -3908,7 +3908,7 @@
             },
             "max_tokens": {
               "title": "Max Tokens",
-              "default": 7,
+              "default": 13,
               "type": "integer"
             },
             "top_k": {
@@ -3918,8 +3918,8 @@
             },
             "temperature": {
               "title": "Temperature",
-              "default": 0,
-              "type": "integer"
+              "default": 0.2,
+              "type": "number"
             },
             "presence_penalty": {
               "title": "Presence Penalty",

diff --git a/haystack/nodes/answer_generator/openai.py b/haystack/nodes/answer_generator/openai.py
@@ -28,9 +28,9 @@ def __init__(
         self,
         api_key: str,
         model: str = "text-curie-001",
-        max_tokens: int = 7,
+        max_tokens: int = 13,
         top_k: int = 5,
-        temperature: int = 0,
+        temperature: float = 0.2,
         presence_penalty: float = -2.0,
         frequency_penalty: float = -2.0,
         examples_context: Optional[str] = None,