Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pillow version to 9.0.0 #1988

Closed
mapapa opened this issue Jan 11, 2022 · 5 comments · Fixed by #1992
Closed

Upgrade pillow version to 9.0.0 #1988

mapapa opened this issue Jan 11, 2022 · 5 comments · Fixed by #1992

Comments

@mapapa
Copy link
Contributor

mapapa commented Jan 11, 2022

Pillow:8.3.2 for python pil/pdfparser.py pdf parsing improper regular expression dos

Pillow package for python contains a flaw in pil/pdfparser.py that is triggered as carriage return characters are not properly handled in a regular expression. this may allow a context-dependent attacker to hang or slow down a python process using the library.

Security source: CVSS V3 from RBS

Fix version: 9.0.0

Thanks

@mapapa
Copy link
Contributor Author

mapapa commented Jan 11, 2022

I am trying to push the respective change but I am getting the following error:
remote: Permission to deepset-ai/haystack.git denied to mapapa.

What am I missing here?

Thanks

@julian-risch
Copy link
Member

Hi @mapapa you need to create a fork of the haystack repository and do a pull request from this fork. Here is a GitHub guide on creating the pull request from a fork: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork but I think once you have created a fork with your changes you won't need the guide. It's easy from there. You'll see. :) If not, happy to help.

@mapapa
Copy link
Contributor Author

mapapa commented Jan 11, 2022

Hi @julian-risch, the issue I am currently facing is that I cannot push my changes to GitHub:
git push -u origin upgrade_pillow
remote: Permission to deepset-ai/haystack.git denied to mapapa.
fatal: unable to access 'https://github.com/deepset-ai/haystack.git/': The requested URL returned error: 403

I am using my personal access token and https as per latest GitHub setup but with no luck.

Any ideas why?

Thanks

@julian-risch
Copy link
Member

julian-risch commented Jan 11, 2022

Hi @mapapa I understand that the problem is still that you are working on the haystack repository itself but not on a fork of it, which you would need to do. Let me walk you through the steps on how to do the changes via your web browser only.

  1. You go to the file that you want to change in your web browser. In your case: https://github.com/deepset-ai/haystack/blob/master/requirements.txt

  2. When you hover on the pen symbol right next to the trash bin in the upper right hand corner, it says "Fork this project and edit the file"
    image

  3. Click on that symbol and now you're editing the file in your fork of the repository. You can make the change in the file directly through the browser.

  4. When you scroll to the bottom of the page, you can commit the change and create a pull request based on that change. All you need to do then is write a short pull request description with a link to the issue that you address with that pull request.

Looking forward to your pull request. :)

PS: Of course you can do that all also with your local git instead of using the web browser. Here is another guide about creating a fork with respect to different operating systems: https://docs.github.com/en/get-started/quickstart/fork-a-repo

@mapapa
Copy link
Contributor Author

mapapa commented Jan 11, 2022

Amazing, I finally raised the pull request. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants