Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pillow version to 9.0.0 #1992

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

mapapa
Copy link
Contributor

@mapapa mapapa commented Jan 11, 2022

Pillow:8.3.2 for python pil/pdfparser.py pdf parsing improper regular expression dos

Pillow package for python contains a flaw in pil/pdfparser.py that is triggered as carriage return characters are not properly handled in a regular expression. this may allow a context-dependent attacker to hang or slow down a python process using the library.

Security source: CVSS V3 from RBS

Fix version: 9.0.0

closes #1988

Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your very first contribution to Haystack! Looks good to me! 👍 All tests are passing and I don't see a reason why not to upgrade the version. The newer version 9.0.0 doesn't support python 3.6 anymore (https://pillow.readthedocs.io/en/stable/installation.html) but we dropped the support for python 3.6 anyway here: #1059

@julian-risch julian-risch changed the title fix pdf parsing improper regular expression dos Upgrade pillow version to 9.0.0 Jan 12, 2022
@julian-risch julian-risch merged commit 965b961 into deepset-ai:master Jan 12, 2022
@mapapa mapapa deleted the upgrade_pillow branch January 13, 2022 12:05
@julian-risch
Copy link
Member

Hello @mapapa I have sent you an email to the address provided in your GitHub profile. Please let me know if you received it. Thank you. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade pillow version to 9.0.0
2 participants