-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Components in Pipelines with REST API #955
Comments
One suggestion that I had from @psorianom is to create some pip packages to deal with custom nodes. |
Hi @guillim, thank you for raising the issue. I think the fundamental premise here is that the I agree with you that the proposed solution with defining nodes in An alternative approach could be defining the custom nodes together with the REST APIs(maybe in a dedicated custom_nodes folder) using a Python decorator( It is an important functionality for Haystack, so happy to brainstorm more ideas to simplify this workflow.
I like the idea, but my first reaction is it might possibly be more work than needed for users to create and publish packages for custom_nodes. |
The I understand (and agree) that most of you users would feel a bit overwhelmed by the need to develop a dedicated pip packeage for this specific purpose. |
Yeah I would also imagine a solution where we mount a |
tks for the job |
Problem
I am handling multiple instances of Haystack, because I have multiple customers with their own knowledge base, and therefore custom needs.
Since the pipelines PR #922, I am seeing a new possibility : having one file rest_api/pipelines.yaml for each one of our customer, keeping the same code base among all of them. It will ease the maintenance, a lot.
However, we have sometimes to create custom nodes such as you suggest in you doc but these components cannot yet be available when using the REST_API and docker.
Describe the solution you'd like
A cleaner way to integrate custom nodes. I am sure my solution isn't clean, but I haven't found a better way yet.
Describe alternatives you've considered
To give you an example, let's say we want to create a slightly modified version of the EmbeddingRetriever.
At the moment, I create a file called haystack/custom.py in which i write my python nodes
and I import them in the haystack/init.py like so
Additional context
For the setup, I am using the REST_API with Docker-compose
The text was updated successfully, but these errors were encountered: