Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CD update #118

Closed
guillim opened this issue Jun 28, 2021 · 1 comment
Closed

CD update #118

guillim opened this issue Jun 28, 2021 · 1 comment
Assignees
@MichaelBitard
Labels
enhancement New feature or request

Comments

@guillim
Copy link
Contributor

guillim commented Jun 28, 2021

Following Haystack update

Following a recent change in Haystack code, we could match their new code version before it breaks on our side :)

  • they implemented the custom_component.py into the rest_api folder in this issue

  • they also added it to a new __init__.py so we can remove our own version in ansible I believe

    piaf-ml/deployment/roles/haystack/tasks/main.yml

    Line 29 in dc86674

    - name: "{{ client }} | copy init.py"

  • I have the feeling they added a new pkg in the requirements.txt called weaviate-client
@guillim guillim added the enhancement New feature or request label Jun 28, 2021
@MichaelBitard MichaelBitard mentioned this issue Jul 9, 2021
Merged
@guillim
Copy link
Contributor Author

guillim commented Jul 13, 2021

Just linking this to this issue I noticed: #127

@guillim guillim closed this as completed Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelBitard MichaelBitard

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichaelBitard @guillim