Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Finder #1326

Merged
merged 3 commits into from
Aug 9, 2021
Merged

Remove Finder #1326

merged 3 commits into from
Aug 9, 2021

Conversation

tholor
Copy link
Member

@tholor tholor commented Aug 9, 2021

Proposed changes:
We deprecated Finder a while ago and replaced it with the more flexible Pipeline. Let's now get finally rid of it :)

If you are still using a Finder, simply replace it with a ExtractiveQAPipeline:

from haystack.pipeline import ExtractiveQAPipeline
pipe = ExtractiveQAPipeline(reader=..., retriever=...)
pipe.run(query="Some question")

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

@tholor tholor changed the title deprecate finder Remove Finder Aug 9, 2021
@lalitpagaria
Copy link
Contributor

lalitpagaria commented Aug 9, 2021

Please add small document or paragraph about way to migrate from Finder to ExtractiveQAPipeline in documentation.
It would be great to have this as part of version history on documentation page.

User have to -

  1. Change import
  2. Class from finder to pipeline
  3. final output from answers to documents

Copy link
Contributor

@lalitpagaria lalitpagaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@tholor tholor merged commit a0921f0 into master Aug 9, 2021
@tholor tholor deleted the remove_finder branch August 9, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants