-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve output of the tutorials #1675
Closed
Closed
Changes from 23 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
00b3908
Improve output of Tutorial11 (.py version only)
ZanSara 67baf0f
Improve output of Tutorial10 (.py only)
ZanSara 2bc14e6
Slightly improve Tutorial8 (.py only)
ZanSara 638d4f4
Reduce level of detail of printed answers in Tutorial11 (.ipynb)
ZanSara 54cbf18
Add latest docstring and tutorial changes
github-actions[bot] abc29ff
Improve output printing of tutorial13 (.py only)
ce3fc38
Improve output of tutorial13 (.ipynb)
ZanSara c9dff47
Add latest docstring and tutorial changes
github-actions[bot] e421a2e
Improve output of Tutorial14 (.py only)
ZanSara fe179e9
Merge branch 'tutorials_output' of github.com:deepset-ai/haystack int…
ZanSara 0148e10
Add the same modifications to the ipynb version of Tutorial14
ZanSara a2973df
Add the same modifications to the ipynb version of Tutorial14
ZanSara 08ed6c5
Add latest docstring and tutorial changes
github-actions[bot] e77b98a
Add a clear message to print_answers in case there are no answers to …
ZanSara c6c0d3e
Merge branch 'tutorials_output' of github.com:deepset-ai/haystack int…
ZanSara 289ef13
Clean up Tutorial14 and rename QueryClassifier to MyQueryClassifier i…
ZanSara 293096c
Add latest docstring and tutorial changes
github-actions[bot] 27d9ff3
Clear all notebooks' output
ZanSara cb84923
Merge branch 'tutorials_output' of github.com:deepset-ai/haystack int…
ZanSara 621a53e
Add latest docstring and tutorial changes
github-actions[bot] 6ea249a
Add more details about how to print the output in Tutorial1
ZanSara 77cfee0
Merge branch 'tutorials_output' of github.com:deepset-ai/haystack int…
ZanSara fb8f662
Add latest docstring and tutorial changes
github-actions[bot] 8cf8627
Add output to the first tutorial's last cell
ZanSara 52d4a0f
Merge branch 'tutorials_output' of github.com:deepset-ai/haystack int…
ZanSara d3c7735
Add latest docstring and tutorial changes
github-actions[bot] fade01f
Modify repr and str for Document and Answer class
ZanSara 843bf24
Merge branch 'tutorials_output' of github.com:deepset-ai/haystack int…
ZanSara File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we also wanted to show the actual output here (at least the first answer in the json and then
...
) 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right! I put it in the .py script but somehow forgot to put it here 🤦