-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rely api healthcheck on status code rather than json decoding #1871
Conversation
Amazing, thank you for the tests especially! Feel free to request a review to me or @tstadel when you think it's ready to be merged 🙂 |
I noticed your tests are failing on the CI. I'll add a commit to your PR to fix the CI, currently is not installing the UI dependencies because we haven't had UI tests before 😅 |
There should be a box on the sidebar on the right of your first comment, titled Reviewers. I can't assign myself as a reviewer, but if you can't find it I will assign @tstadel or ask him to assign me 🙂 |
Mmmh, I can see the "assignees" section on the right sidebar, but I can't edit it in anyway. I guess I don't have the appropriate level access, so feel free to assign it to one of you! |
Thanks again for your contribution 🙂 As soon as the CI completes on master, the new docker images should be uploaded on the Hub and ready to use. |
Proposed changes:
It is related to this issue: #1866
Status (please check what you already did):