Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely api healthcheck on status code rather than json decoding #1871

Merged
merged 3 commits into from
Dec 10, 2021
Merged

Rely api healthcheck on status code rather than json decoding #1871

merged 3 commits into from
Dec 10, 2021

Conversation

fabiolab
Copy link
Contributor

@fabiolab fabiolab commented Dec 10, 2021

Proposed changes:

  • Change the way to check api status from ui: set it on status_code rather than json decoding

It is related to this issue: #1866

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

@ZanSara
Copy link
Contributor

ZanSara commented Dec 10, 2021

Amazing, thank you for the tests especially! Feel free to request a review to me or @tstadel when you think it's ready to be merged 🙂

@ZanSara ZanSara linked an issue Dec 10, 2021 that may be closed by this pull request
1 task
@tstadel
Copy link
Member

tstadel commented Dec 10, 2021

Yes, looks like it's ready to review :-).
@fabiolab just feel free, to request a review from me and/or @ZanSara.

@ZanSara
Copy link
Contributor

ZanSara commented Dec 10, 2021

I noticed your tests are failing on the CI. I'll add a commit to your PR to fix the CI, currently is not installing the UI dependencies because we haven't had UI tests before 😅

@fabiolab
Copy link
Contributor Author

Yes, looks like it's ready to review :-). @fabiolab just feel free, to request a review from me and/or @ZanSara.

Yes, I don't see what to do else! It's ready from my point of view. But I can't find out how to assign the PR to one of you.

@ZanSara
Copy link
Contributor

ZanSara commented Dec 10, 2021

There should be a box on the sidebar on the right of your first comment, titled Reviewers. I can't assign myself as a reviewer, but if you can't find it I will assign @tstadel or ask him to assign me 🙂

@fabiolab
Copy link
Contributor Author

Mmmh, I can see the "assignees" section on the right sidebar, but I can't edit it in anyway. I guess I don't have the appropriate level access, so feel free to assign it to one of you!

@ZanSara ZanSara requested a review from tstadel December 10, 2021 15:20
@tstadel tstadel requested a review from ZanSara December 10, 2021 15:28
@ZanSara ZanSara merged commit 77d52ad into deepset-ai:master Dec 10, 2021
@ZanSara
Copy link
Contributor

ZanSara commented Dec 10, 2021

Thanks again for your contribution 🙂 As soon as the CI completes on master, the new docker images should be uploaded on the Hub and ready to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSONDecodeError during haystack_is_ready()
4 participants