Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate duplicate_documents to base class initialization #1936

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Propagate duplicate_documents to base class initialization #1936

merged 2 commits into from
Jan 4, 2022

Conversation

yorickvanzweeden
Copy link
Contributor

@yorickvanzweeden yorickvanzweeden commented Dec 30, 2021 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • [X ] First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

@tholor tholor requested a review from tstadel January 3, 2022 10:04
tstadel
tstadel approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@tstadel tstadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tstadel tstadel added topic:document_store type:bug Something isn't working labels Jan 4, 2022
@tstadel tstadel changed the title Add duplicate_documents to base class initialization Propagate duplicate_documents to base class initialization Jan 4, 2022
@tstadel tstadel merged commit 180befd into deepset-ai:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstadel tstadel tstadel approved these changes

Assignees
No one assigned
Labels
topic:document_store type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The duplicate_documents argument for Milvus is overwritten by SQLDocumentStore
2 participants
@yorickvanzweeden @tstadel