Add models to demo docker image #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julian-risch
requested changes
Jan 10, 2022
|
I don't see anymore logs related to punkt when starting the image for the first time, let me know if it works for you too! 🙂 |
ZanSara
added
journey:first steps
topic:docker
type:feature
julian-risch
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a small utility to download and cache the demo's model and NLTK data, then modifies Dockerimage and Dockerimage-GPU to call this function at build time.
This will provide users with a demo that does not need to download any model at its first run, making the demo installation process easier and a bit faster too.
Closes #1652