Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix elasticsearch scores if they are 0.0 #1980

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Fix elasticsearch scores if they are 0.0 #1980

merged 2 commits into from
Jan 11, 2022

Conversation

tstadel
Copy link
Member

@tstadel tstadel commented Jan 10, 2022

Proposed changes:

  • do not set scores to None if the returned score from elasticsearch is 0.0

impact:
Downstream nodes like JoinDocumentcannot deal with None scores.

fixes #1911

@tstadel tstadel requested a review from oryx1729 January 10, 2022 14:13
@tstadel
Copy link
Member Author

tstadel commented Jan 10, 2022

@oryx1729
are there any situations I'm missing we want scores of 0.0 to be set to None?

@tstadel tstadel mentioned this pull request Jan 10, 2022
Closed
@oryx1729
Copy link
Contributor

@oryx1729
are there any situations I'm missing we want scores of 0.0 to be set to None?

I think this should be the only place.

@tstadel tstadel merged commit 192e03b into master Jan 11, 2022
@tstadel tstadel deleted the fix_es_zero_scores branch January 11, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oryx1729 oryx1729 oryx1729 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None score for some files
2 participants
@tstadel @oryx1729