Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Milvus to <2.0.0 #2063

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Pin Milvus to <2.0.0 #2063

merged 1 commit into from
Jan 25, 2022

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Jan 25, 2022

Due to the new 2.0.0 release, we should pin pymilvus<2.0.0 for now

Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's create another issue though to make sure haystack also works with pymilvus 2.0 (and beyond in future). The comment here on
# For milvus 2.x version use this library 'pymilvus===2.0.0rc6' can also be removed then.

@ZanSara
Copy link
Contributor Author

ZanSara commented Jan 25, 2022

The incoming PR on dependency management (#1994) actually takes care of this Milvus breaking change: there are two different dependency groups for both versions. Do you think I should change the default to Milvus2? Our integration with it not yet very well tested, but on the other hand if we never use it we'll never know if it works 😄

@julian-risch
Copy link
Member

julian-risch commented Jan 25, 2022

if haystack works with 2.0 thanks to the upcoming #1994 PR, I would be happy to have 2.0 as the default, yes. Knowing whether it works or not that's what our test cases are for ;)

@ZanSara
Copy link
Contributor Author

ZanSara commented Jan 25, 2022

Cool, then let's leave this one as it is as a quick patch. I believe #1994 could be merged tomorrow or after-tomorrow at most.

@HAIXteam
Copy link

Hello, We are having an issue with pymilvus. please advise any help on this?

1)we installled farm-haystack==0.9.0
2) We installed pip3 install pymilvus==1.1.2

File "/app/main.py", line 6, in
from haystack import document_store
File "/usr/local/lib/python3.7/site-packages/haystack/init.py", line 5, in
from haystack.finder import Finder
File "/usr/local/lib/python3.7/site-packages/haystack/finder.py", line 8, in
from haystack.reader.base import BaseReader
File "/usr/local/lib/python3.7/site-packages/haystack/reader/init.py", line 1, in
from haystack.reader.farm import FARMReader
File "/usr/local/lib/python3.7/site-packages/haystack/reader/farm.py", line 21, in
from haystack.document_store.base import BaseDocumentStore
File "/usr/local/lib/python3.7/site-packages/haystack/document_store/init.py", line 4, in
from haystack.document_store.milvus import MilvusDocumentStore
File "/usr/local/lib/python3.7/site-packages/haystack/document_store/milvus.py", line 7, in
from milvus import IndexType, MetricType, Milvus, Status
ModuleNotFoundError: No module named 'milvus'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants