Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List all pipeline(_configs) on Deepset Cloud #2102

Merged
merged 10 commits into from
Feb 8, 2022
Merged

Conversation

tstadel
Copy link
Member

@tstadel tstadel commented Feb 2, 2022

Proposed changes:

  • add Pipeline.list_pipelines_on_deepset_cloud()
  • add docstrings to Pipeline.load_from_deepset_cloud() on how to get a list of available pipeline_config_names.

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

@tstadel tstadel requested a review from ZanSara February 2, 2022 10:00
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference between get and get_paginated I think deserves some clarification, for the rest is ok. The other two comments are less important, but I think they're also gonna improve the code a bit 🙂

haystack/utils/deepsetcloud.py Outdated Show resolved Hide resolved
haystack/utils/deepsetcloud.py Show resolved Hide resolved
haystack/utils/deepsetcloud.py Show resolved Hide resolved
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like a lot the new implementation! 👍

@ZanSara
Copy link
Contributor

ZanSara commented Feb 8, 2022

One more thing: please run mypy locally as I made a mistake in the CI and it now occasionally fails or skips, like it happened here 😅 I'm working on it

@tstadel tstadel merged commit 1e3edef into master Feb 8, 2022
@tstadel tstadel deleted the list_pipelines_on_dc branch February 8, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants