Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join node should allow reciprocal rank fusion as additional merging method #2133

Merged
merged 14 commits into from
Feb 10, 2022

Conversation

mathislucka
Copy link
Member

@mathislucka mathislucka commented Feb 7, 2022

Proposed changes:

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but there are a few possible improvements 🙂 Please don't hesitate to question my comments if they don't feel right! I tend to be a bit tedious sometimes 😄

haystack/nodes/other/join_docs.py Outdated Show resolved Hide resolved
haystack/nodes/other/join_docs.py Outdated Show resolved Hide resolved
haystack/nodes/other/join_docs.py Outdated Show resolved Hide resolved
haystack/nodes/other/join_docs.py Outdated Show resolved Hide resolved
haystack/nodes/other/join_docs.py Outdated Show resolved Hide resolved
@mathislucka
Copy link
Member Author

Hey @ZanSara thanks for the thorough review :) @dmigo and I refactored a little bit and it's hopefully a cleaner version now.

Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it's good to go for me!

If you have the time, though, I'd split test_join_document_pipeline into several smaller tests. Why having such a huge test when the units within it are so visible? 🙂

@ZanSara
Copy link
Contributor

ZanSara commented Feb 8, 2022

One last comment: please run mypy locally before merging, as I noticed a bug into one of my latest CI changes that sometimes make the check fail for a cache miss. If mypy shows no errors, then it's good to merge: the Ray issue is known and will not cause problems.

@dmigo
Copy link
Member

dmigo commented Feb 8, 2022

If you have the time, though, I'd split test_join_document_pipeline into several smaller tests.

😆 we've also discussed that that would be nice to do

@mathislucka mathislucka merged commit f11494a into master Feb 10, 2022
@mathislucka mathislucka deleted the add_reciprocal_rank_fusion branch February 10, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants