-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Join node should allow reciprocal rank fusion as additional merging method #2133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but there are a few possible improvements 🙂 Please don't hesitate to question my comments if they don't feel right! I tend to be a bit tedious sometimes 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, it's good to go for me!
If you have the time, though, I'd split test_join_document_pipeline
into several smaller tests. Why having such a huge test when the units within it are so visible? 🙂
One last comment: please run mypy locally before merging, as I noticed a bug into one of my latest CI changes that sometimes make the check fail for a cache miss. If mypy shows no errors, then it's good to merge: the Ray issue is known and will not cause problems. |
😆 we've also discussed that that would be nice to do |
Proposed changes:
Status (please check what you already did):