Add aiorwlock to 'ray' extra & fix maximum version for some dependencies #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathislucka
requested changes
Feb 9, 2022
There was a problem hiding this comment.
I think the PR generally looks good. I can't run the full test suite locally so I'd trust this to fix the failing ray test.
And now a tiny nitpick :)
However, I think you should change the title because as far as I understand, you are not just adding aiorwlock but you are also fixing some other dependencies to stay below the next major version. I think having the title like this could make it hard to figure this out later.
ZanSara
changed the title
|
Honest 😁 I updated the title, I will not modify it further at merge. |
oryx1729
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest Ray release made
aiorwlocka required package. This PR addsaiorwlockto therayextra dependency group.It also fixes the range some dependencies which had no upper limit yet.