Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reader/base.py to fix UnboundLocalError in #2273 #2275

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Update reader/base.py to fix UnboundLocalError in #2273 #2275

merged 1 commit into from
Mar 7, 2022

Conversation

thimo72
Copy link
Contributor

@thimo72 thimo72 commented Mar 4, 2022

Proposed changes:

  • moved the predict assignment from line 82 to line 81 in reader/base.py

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

@thimo72 thimo72 changed the title Update reader/base.py to fix UnboundLocalError Update reader/base.py to fix UnboundLocalError in #2273 Mar 4, 2022
@tstadel tstadel self-requested a review March 4, 2022 14:17
tstadel
tstadel approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@tstadel tstadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Unfortunately we had some dependency issues and to make the tests run appropriately, we would have to merge the changes into the fork branch. As this change is very small we can make an exception and run the tests on master only.

@tstadel tstadel merged commit ccef3ef into deepset-ai:master Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstadel tstadel tstadel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thimo72 @tstadel