Remove wrong retriever top_1 metrics from print_eval_report
#2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julian-risch
requested changes
May 10, 2022
| @@ -785,6 +785,7 @@ def test_extractive_qa_eval_wrong_examples(reader, retriever_with_docs): | |||
|
|
|||
| @pytest.mark.parametrize("retriever_with_docs", ["tfidf"], indirect=True) | |||
| @pytest.mark.parametrize("document_store_with_docs", ["memory"], indirect=True) | |||
| @pytest.mark.parametrize("reader", ["farm"], indirect=True) | |||
There was a problem hiding this comment.
This excludes the TransformersReader from this test, which is a good change in my opinion. I was just surprised to find it here. Now that you are at it, please check also the other tests in test_eval.py. For example, I see that the same change could be made to test_extractive_qa_eval_translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently top_1 metrics are shown for Retriever metrics too although they were calculated with
simulated_top_k_reader=1. This is confusing and plain wrong. We should not show top_1 Retriever metrics at all.Proposed changes:
print_eval_reportn_wrong_examplesis0Status (please check what you already did):
@Timoeller @neo-alex