Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust pydoc markdown config so methods shown with classes #2511

Merged
merged 8 commits into from
May 6, 2022

Conversation

brandenchan
Copy link
Contributor

@brandenchan brandenchan commented May 6, 2022

Currently, on the documentation website, the Reference API section is quite hard to read. When you scroll down to a method, you might have to scroll a long way up to find which class it is part of. This PR changes a pydoc markdown param so that the class from which the method comes from is always included.

e.g. ElasticsearchDocumentStore.get_all_documents() instead of just get_all_documents()

@brandenchan
Copy link
Contributor Author

Methods now appear in reference docs with their class

Screenshot from 2022-05-06 15-48-03

Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍 Nice feature!

@brandenchan brandenchan merged commit caf1336 into master May 6, 2022
@brandenchan brandenchan deleted the methods_with_classes branch May 6, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants