Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update run() and run_batch() params descriptions in API #2542

Merged
merged 8 commits into from
May 13, 2022
Merged

Update run() and run_batch() params descriptions in API #2542

merged 8 commits into from
May 13, 2022

Conversation

agnieszka-m
Copy link
Contributor

No description provided.

@agnieszka-m agnieszka-m added the type:documentation Improvements on the docs label May 12, 2022
@agnieszka-m agnieszka-m self-assigned this May 12, 2022
@CLAassistant
Copy link

CLAassistant commented May 13, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@agnieszka-m @bogdankostic
Fix typo
e5ac096 
Co-authored-by: bogdankostic <bogdankostic@web.de>
bogdankostic
bogdankostic suggested changes May 13, 2022
View reviewed changes
Copy link
Contributor

@bogdankostic bogdankostic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking already good, only left a few minor comments. Also, the CI is complainig about the CLA not being signed.

haystack/pipelines/base.py Outdated Show resolved Hide resolved
bogdankostic
bogdankostic approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@bogdankostic bogdankostic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agnieszka-m agnieszka-m merged commit 1ae5a14 into master May 13, 2022
@agnieszka-m agnieszka-m deleted the run-batch-doc-update branch May 13, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdankostic bogdankostic bogdankostic approved these changes

Assignees

@agnieszka-m agnieszka-m

Labels
topic:pipeline type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agnieszka-m @CLAassistant @bogdankostic