Add run_batch for standard pipelines
#2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julian-risch
requested changes
May 25, 2022
There was a problem hiding this comment.
Looks very good to me already! 👍 The only change I would like to see made is in RetrieverQuestionGenerationPipeline. Both run and run_batch have the same code. So I'd argue that run should call run_batch internally instead of duplicating the code. What do you think?
| @@ -495,3 +563,21 @@ def run(self, document_ids: List[str], top_k: int = 5): | |||
|
|
|||
| self.document_store.return_embedding = False # type: ignore | |||
| return similar_documents | |||
|
|
|||
| def run_batch(self, document_ids: List[str], top_k: int = 5): # type: ignore | |||
There was a problem hiding this comment.
the code of run_batch is exactly the same as for run here. So I'd say it's better to call run from within run_batch and avoid code duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2481, we added the possibility to run batches of queries through a Pipeline. This PR adds makes this possible also for standard pipelines by adding
run_batchmethods.