Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pipeline.eval with context matching for Table-QA #2597

Merged
merged 1 commit into from
May 25, 2022
Merged

Fix pipeline.eval with context matching for Table-QA #2597

merged 1 commit into from
May 25, 2022

Conversation

tstadel
Copy link
Member

@tstadel tstadel commented May 25, 2022

Proposed changes:

  • before context matching, if context is dataframe convert it to string
  • this also adds a missing update_embeddings statement to the py file of tutorial 15

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code

@tstadel tstadel requested a review from ZanSara May 25, 2022 13:08
ZanSara
ZanSara approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😊

@ZanSara ZanSara merged commit dd8dc58 into master May 25, 2022
@ZanSara ZanSara deleted the fix_table_qa_eval branch May 25, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZanSara ZanSara ZanSara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tstadel @ZanSara