Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Docs Readabilty #2617

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Improve Docs Readabilty #2617

merged 2 commits into from
Jun 3, 2022

Conversation

ryanrussell
Copy link
Contributor

Proposed changes:

  • Improve readability across some 80+ files(Sounds high due to including historical docs)

Status (please check what you already did):

global grep was run to validate variable name changes in .py files changed.

Specifically:

haystack/pipelines/base.py
tutorials/Tutorial1_Basic_QA_Pipeline.py
tutorials/Tutorial5_Evaluation.py

Finally, there was a push merging just now before this push. Merged deepset-ai.master -> ryanrussell.master to handle.

Please let me know if there are any issues.

ryanrussell and others added 2 commits May 31, 2022 10:10
@ryanrussell
Improve Docs Readability
e3a8e56 
Signed-off-by: Ryan Russell <git@ryanrussell.org>
@ryanrussell
Merge branch 'deepset-ai:master' into master
8a0ba6b
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@CLAassistant
Copy link

CLAassistant commented May 31, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@bogdankostic bogdankostic added type:documentation Improvements on the docs ignore-for-release-notes PRs with this flag won't be included in the release notes. labels Jun 2, 2022
@agnieszka-m agnieszka-m merged commit c1b7948 into deepset-ai:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnieszka-m agnieszka-m agnieszka-m approved these changes

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ryanrussell @CLAassistant @agnieszka-m @ZanSara @bogdankostic