Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EvaluationSetCliet.get_labels() #2690

Merged
merged 3 commits into from
Jun 20, 2022
Merged

Fix EvaluationSetCliet.get_labels() #2690

merged 3 commits into from
Jun 20, 2022

Conversation

tstadel
Copy link
Member

@tstadel tstadel commented Jun 20, 2022

Proposed changes:

  • fixes getting labels from deepset Cloud (needs name instead of id as path param)

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code

@tstadel tstadel requested review from masci and mkkuemmel June 20, 2022 16:24
@mkkuemmel
Copy link
Member

lgtm

masci
masci approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tstadel tstadel merged commit da5ea73 into master Jun 20, 2022
@tstadel tstadel deleted the fix_dc_evalset_labels branch June 20, 2022 17:16
Krak91 pushed a commit to Krak91/haystack that referenced this pull request Jul 26, 2022
@tstadel @github-actions
Fix EvaluationSetCliet.get_labels() (deepset-ai#2690)
b375ce7 
* fix EvaluationSetCliet.get_labels()

* Update Documentation & Code Style

* fix tests

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

@mkkuemmel mkkuemmel Awaiting requested review from mkkuemmel

Assignees
No one assigned
Labels
topic:dc_document_store type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tstadel @mkkuemmel @masci