Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated Selenium methods #2724

Merged
merged 3 commits into from
Jun 24, 2022
Merged

Replace deprecated Selenium methods #2724

merged 3 commits into from
Jun 24, 2022

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Jun 24, 2022

@ZanSara ZanSara requested a review from masci June 24, 2022 09:10
masci
masci approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 2 tests failures and are expected

@ZanSara ZanSara merged commit e8546e2 into master Jun 24, 2022
@ZanSara ZanSara deleted the selenium-upgrade branch June 24, 2022 10:05
Krak91 pushed a commit to Krak91/haystack that referenced this pull request Jul 26, 2022
@ZanSara @danielbichuetti
Replace deprecated Selenium methods (deepset-ai#2724)
53bd8c1 
* Fix crawler.py

* Fix test_connector.py

* unused import

Co-authored-by: danielbichuetti <daniel.bichuetti@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

Assignees
No one assigned
Labels
topic:crawler topic:tests type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZanSara @masci