Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix match_context tests in test_utils.py #2725

Merged
merged 5 commits into from
Jun 24, 2022
Merged

Conversation

tstadel
Copy link
Member

@tstadel tstadel commented Jun 24, 2022

Related Issue(s): ...

Proposed changes:

Pre-flight checklist

  • If this is a code change, I added tests or updated existing ones

@tstadel tstadel requested a review from masci June 24, 2022 09:34
@tstadel tstadel added type:bug Something isn't working ignore-for-release-notes PRs with this flag won't be included in the release notes. labels Jun 24, 2022
test/others/test_utils.py Show resolved Hide resolved
test/others/test_utils.py Show resolved Hide resolved
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2 failures are expected, LGTM

@ZanSara ZanSara merged commit ab443aa into master Jun 24, 2022
@ZanSara ZanSara deleted the fix_match_context_tests branch June 24, 2022 11:23
Krak91 pushed a commit to Krak91/haystack that referenced this pull request Jul 26, 2022
* fix match_context tests

* fix naming of test

* pin rapidfuzz to 2.0.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants