Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: FAISS in OpenSearch: Support HNSW for dot product and l2 #3029

Merged
merged 9 commits into from
Aug 24, 2022
Merged

feat: FAISS in OpenSearch: Support HNSW for dot product and l2 #3029

merged 9 commits into from
Aug 24, 2022

Conversation

tstadel
Copy link
Member

@tstadel tstadel commented Aug 11, 2022 •
edited
Loading

Related Issues

Proposed Changes:

  • add param knn_engine with default "nmslib" to constructor
  • set index mappings: use the same hnsw params as for nmslib
  • throw on other similarity types

How did you test it?

Notes for the reviewer

Checklist

@tstadel tstadel requested review from a team as code owners August 11, 2022 16:07
agnieszka-m
agnieszka-m requested changes Aug 12, 2022
View reviewed changes
haystack/document_stores/opensearch.py Outdated Show resolved Hide resolved
haystack/document_stores/opensearch.py Outdated Show resolved Hide resolved
haystack/document_stores/opensearch.py Outdated Show resolved Hide resolved
masci and others added 2 commits August 18, 2022 11:50
@masci @agnieszka-m
Apply suggestions from code review
f2e8249 
Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
@masci
regenerate docs
a897c88
@masci masci requested a review from agnieszka-m August 18, 2022 09:52
@bogdankostic bogdankostic linked an issue Aug 18, 2022 that may be closed by this pull request
FAISS in OpenSearch: Support HNSW for dot product and l2 #2911
Closed
3 tasks
@bogdankostic bogdankostic merged commit 92046ce into main Aug 24, 2022
@bogdankostic bogdankostic deleted the feature/os_faiss_basic branch August 24, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdankostic bogdankostic bogdankostic approved these changes

@agnieszka-m agnieszka-m agnieszka-m approved these changes

Assignees
No one assigned
Labels
topic:document_store topic:opensearch type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FAISS in OpenSearch: Support HNSW for dot product and l2
4 participants
@tstadel @bogdankostic @agnieszka-m @masci