Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: OpensearchDocumentStore.custom_mapping should accept JSON strings at validation #3065

Merged
merged 1 commit into from
Aug 29, 2022
Merged

bug: OpensearchDocumentStore.custom_mapping should accept JSON strings at validation #3065

merged 1 commit into from
Aug 29, 2022

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Aug 18, 2022

Related Issues

Proposed Changes:

Add custom_mapping to the list of fields that accept JSON input.

How did you test it?

Add a line into an existing unit test

Checklist

@ZanSara ZanSara marked this pull request as ready for review August 22, 2022 08:17
@ZanSara ZanSara requested a review from a team as a code owner August 22, 2022 08:17
@ZanSara ZanSara requested review from vblagoje and removed request for a team August 22, 2022 08:17
masci
masci approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZanSara ZanSara merged commit e88f1e2 into main Aug 29, 2022
@ZanSara ZanSara deleted the custom-mapping-is-json branch August 29, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

@vblagoje vblagoje Awaiting requested review from vblagoje vblagoje is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
topic:document_store topic:opensearch type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpensearchDocumentStore.custom_mapping fails validation
2 participants
@ZanSara @masci