-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update package strategy in rest_api #3148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Overall I found only a few links to fix, one minor question mark, and I'm super interested about __about__.py
for some reason 😄
Source = "https://github.com/unknown/rest-api" | ||
|
||
[tool.hatch.version] | ||
path = "rest_api/__about__.py" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is new!
I've googled it quickly and found some references in SO, but no official docs. Is it a style choice or something actually recommended for packages? I like it, and if it's a standard I'd like to see it in Haystack as well someday in place of the VERSION.txt
file 🤩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's standard but it looks like a good practice. I got it from the default template used by hatch
when you bootstrap a new project, it can be definitely ported to Haystack at some point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Related Issues
Part of: #3085
At this moment it's not possible to install
rest_ui
unless it's in editable mode, which prevents optimising Haystack's Dockerfiles.Proposed Changes:
Refactor the packaging so that
rest_api
can be properly installedHow did you test it?
pip install /path/to/haystack-repo/rest_api
Notes for the reviewer
Checklist