fix: add type hints to all component __init__ constructor parameters #3152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vblagoje
requested review from
masci and
brandenchan
and removed request for
a team and
masci
brandenchan
suggested changes
Sep 5, 2022
| @@ -44,6 +44,7 @@ class EntityExtractor(BaseComponent): | |||
| def __init__( | |||
| self, | |||
| model_name_or_path: str = "dslim/bert-base-NER", | |||
| model_version: Optional[str] = None, | |||
There was a problem hiding this comment.
Let's add a line in the docstring for this param
brandenchan
suggested changes
Sep 5, 2022
| self, | ||
| knowledge_graph: BaseKnowledgeGraph, | ||
| model_name_or_path: str, | ||
| model_version: Optional[str] = None, |
There was a problem hiding this comment.
Let's add a line in the docstring for this param
There was a problem hiding this comment.
Right, totally forgot - thanks Branden
|
@brandenchan should be rebased and ready to go now. Please have another look |
… where applicable
masci
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
__init__constructor parameters #3144Proposed Changes:
Make sure all components have all
__init__parameters typedMake sure all components have the
model_versionoptional parameter - where applicableHow did you test it?
No additional tests were added, verified schema has changed.
Notes for the reviewer
Please make sure all components now have all
__init__parameters typedPlease make sure all components now have
model_versionparameter - if applicable