Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove pre haystack-1.0 import paths support #3204

Merged
merged 2 commits into from
Sep 13, 2022
Merged

refactor: remove pre haystack-1.0 import paths support #3204

merged 2 commits into from
Sep 13, 2022
+0 −179

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Sep 12, 2022 •
edited
Loading

Related Issues

Proposed Changes:

  • Remove import redirect mechanism to support pre Haystack 1.0 import paths

How did you test it?

  • CI

Checklist

@ZanSara ZanSara added topic:installation type:refactor Not necessarily visible to the users topic:dependencies labels Sep 12, 2022
@ZanSara ZanSara requested a review from a team as a code owner September 12, 2022 15:48
@ZanSara ZanSara requested review from bogdankostic and removed request for a team September 12, 2022 15:48
@ZanSara ZanSara changed the title Remove imports redirect refactor: remove pre haystack-1.0 import paths support Sep 12, 2022
@ZanSara ZanSara requested review from masci and removed request for bogdankostic September 12, 2022 15:49
@ZanSara ZanSara mentioned this pull request Sep 13, 2022
Closed
6 tasks
masci
masci approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the PR flavor I love the most 😄

@ArzelaAscoIi ArzelaAscoIi merged commit b47c939 into main Sep 13, 2022
@ArzelaAscoIi ArzelaAscoIi deleted the remove-old-imports branch September 13, 2022 10:16
brandenchan pushed a commit that referenced this pull request Sep 21, 2022
@ZanSara @brandenchan
remove imports redirect (#3204)
65e7e13
@masci masci mentioned this pull request Nov 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

Assignees
No one assigned
Labels
topic:dependencies topic:installation type:refactor Not necessarily visible to the users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pre 1.0 redirect import paths break unittest.mock.patch
3 participants
@ZanSara @masci @ArzelaAscoIi