Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix milvus and faiss tests not running #3263

Merged
merged 9 commits into from
Sep 22, 2022
Merged

Fix milvus and faiss tests not running #3263

merged 9 commits into from
Sep 22, 2022
+75 −36

Conversation

tstadel
Copy link
Member

@tstadel tstadel commented Sep 21, 2022

Related Issues

Proposed Changes:

  • better inferencing of required document store
  • fixed an issue with `test_faiss_and_milvus.py::test_cosine_similarity

How did you test it?

  • well actually run them finally

Notes for the reviewer

this is a follow-up PR to #3252

Checklist

@tstadel tstadel requested a review from a team as a code owner September 21, 2022 18:17
@tstadel tstadel requested review from vblagoje and ZanSara and removed request for a team September 21, 2022 18:17
@tstadel tstadel added type:bug Something isn't working topic:tests labels Sep 21, 2022
ZanSara
ZanSara approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow selecting the right docstore is so complex at this point 😅 We'll get rid of this flawed logic with the tests refactor, one day...

@ZanSara ZanSara removed the request for review from vblagoje September 22, 2022 09:34
@tstadel tstadel merged commit 4fa9d2d into main Sep 22, 2022
@tstadel tstadel deleted the fix_faiss_milvus_tests branch September 22, 2022 15:46
@masci masci added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZanSara ZanSara ZanSara approved these changes

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tstadel @ZanSara @masci