-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add latest benchmark results for v1.9.0 #3339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see some benchmarks again. I have a couple thoughts on this. Versioning is now handled differently in Haystack. v1.9.x now has its own branch and v1.9.0 has its own tag on this branch. If that's the case, we should perform the benchmarks on v1.9.0 and commit the results to the v1.9.x branch.
The benchmarks were performed on the tag v1.9.0, so not sure what you exactly request here?
Happy to merge this PR into the 1.9.0 branch and not |
Just adding this here:
|
That wasn't a request to benchmark differently, just a request that these benchmark results are merged into another branch. If we do adopt this style where each version branch (e.g. v1.9.x) only has one set of benchmarking results, I would say that they could be saved in a |
Ok created a new PR #3355 that will merge the changes into the requested |
Proposed Changes
After (quick)fixing the benchmarks in #2766, I ran all of them now on tag
v1.9.0
(i.e. commit ce36be8) to get some up-to-date results.Few high-level observations from comparing the results to the last version of benchmarks we had (used the ones stored here for v1.8.0, but pretty sure we updated them properly the last time for v0.8.0 and then just carried over to newer versions).
Reader
Retriever
Hardware
All benchmarks were run with:
Notes for the reviewer
Not sure where to place the benchmarks results best in our new repo structure after the docs refactoring.
We used to have results in docs/v1.X.X/benchmarks but I guess we don't have these anymore after the migration of the docs?
Open for any suggestions here. Just important to keep it somehow tied to the v1.9.0 tag so that we which commit these results can be associated to.
Checklist