refactor: Change no_answer attribute

[anakin87]

Related Issues

• fixes Label skips answer validation if no_answer=None #3181

Proposed Changes:

Make answer validation always run, when instantiating a Label,
as suggested by @wochinge in #3181.

How did you test it?

• CI
• Added a test for a Label with invalid answer

Checklist

• I have read the contributors guidelines and the code of conduct
• I have updated the related issue with new insights and changes
• I added tests that demonstrate the correct behavior of the change
• I've used the conventional commit convention for my PR title
• I documented my code
• I ran pre-commit hooks and fixed any issue

[anakin87]

Apparently, this modification is breaking fewer things/tests than I thought.

@ZanSara:

• Do you see any risky code changes?
• Do you have any tests in mind to add?

[ZanSara]

Hey @anakin87! I had a look and I'm really happy about this one. It's crazy how much useless code you removed already 🤩

No need to go ahead and remove no_answer for good: this is already totally worth merging as it is.

I don't see any dangerous change to be honest, especially because the value itself is still there in form of a property, so it's way less prone to break things. I also don't believe we need any tests for such a simple property.

I'll open a new issue with the details of what needs to be done to get rid of the property in the future. I'll tag you just to let you add any insights you might have, and if you want, to assist the next contributor that wants to test themselves with a big PR 😊

[anakin87]

@ZanSara It's always a pleasure to remove (hopefully) unnecessary code. 🙂

I'm just wondering: how are the guides in the documents updated?
I can find pages like this, where no_answer is used in the initialization of the Label...

[ZanSara]

Hey great question! 😄 Let me ask @brandenchan or @TuanaCelik

[brandenchan]

Hey, we've migrated the docs away from GitHub and are now a managed service called Readme. If you see something that can be changed, you can suggest it with the "Suggest Edits" button that is in the top right underneath the search bar

[ZanSara]