Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: update pyworld pin #3435

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Fix: update pyworld pin #3435

merged 2 commits into from
Oct 20, 2022

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

As deeply discussed in the issue, for compatibility with different python versions,
I apply this pin in pyproject:

audio = [
  "pyworld>=0.3.1; python_version >= '3.8'",
  "pyworld<0.3.1; python_version < '3.8'",

How did you test it?

Manual verification with different python versions

Checklist

@anakin87 anakin87 requested a review from a team as a code owner October 20, 2022 08:15
@anakin87 anakin87 requested review from vblagoje and removed request for a team October 20, 2022 08:15
ZanSara
ZanSara approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ZanSara ZanSara removed the request for review from vblagoje October 20, 2022 10:28
@ZanSara ZanSara merged commit abdcb81 into deepset-ai:main Oct 20, 2022
@anakin87 anakin87 deleted the update_pyworld_pin branch October 20, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZanSara ZanSara ZanSara approved these changes

Assignees
No one assigned
Labels
topic:audio topic:dependencies type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audio nodes not working with Python 3.10.4
2 participants
@anakin87 @ZanSara