Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix release number #3559

Merged
merged 7 commits into from
Nov 15, 2022
Merged

bug: fix release number #3559

merged 7 commits into from
Nov 15, 2022

Conversation

mayankjobanputra
Copy link
Contributor

@mayankjobanputra mayankjobanputra commented Nov 11, 2022

Related Issues

Proposed Changes:

Added Haystack_version variable in the docker build workflow. Before this change HAYSTACK_VERSION variable was getting "main" as the default value and every time it would take the "latest changes" from the "main" branch instead of the commit that is tagged with the specific version tag.

Notes for the reviewer

In case you want to verify, you can run following steps:
docker run -it --rm deepset/haystack:base-gpu-v0.0.7 python -c"import haystack;print(haystack.__version__)"

Expected output:
Status: Downloaded newer image for deepset/haystack:base-gpu-v0.0.7
0.0.7

How did you test it?

I manually added a dummy tag and ensured that the new image with the correct version was built and pushed.

Logs of Docker build action:

[base-cpu linux/amd64 build-image 4/9] RUN echo "Version check!!\n"
0.105 Version check!!
0.105
DONE 0.1s

[base-cpu linux/amd64 build-image 5/9] RUN echo v0.0.7
0.214 v0.0.7
DONE 0.3s

Checklist

@mayankjobanputra mayankjobanputra requested a review from a team as a code owner November 11, 2022 18:42
@mayankjobanputra mayankjobanputra requested review from ZanSara and removed request for a team November 11, 2022 18:42
@mayankjobanputra mayankjobanputra self-assigned this Nov 11, 2022
@masci masci removed the epic:in-progress Epic is in progress label Nov 14, 2022
@ZanSara ZanSara marked this pull request as draft November 14, 2022 13:53
@mayankjobanputra mayankjobanputra marked this pull request as ready for review November 14, 2022 14:10
@mayankjobanputra mayankjobanputra changed the title Fix release number bug: fix release number Nov 14, 2022
@masci masci modified the milestone: 1.11.0 Nov 15, 2022
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! 👍

@mayankjobanputra mayankjobanputra merged commit 3098440 into main Nov 15, 2022
@mayankjobanputra mayankjobanputra deleted the mayank/rel_version branch November 15, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Haystack version within docker images
3 participants