-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamlit UI Evaluation mode #920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love to see the functionality in our streamlit app.
I made a comment to make it more adjustable from the outside.
Does it make sense to create tests about this feature and resulting feedback labels?
… not needed dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the detailed user feedback section to our docs.
I made some more comments on the code.
There was also an open comment about file upload or attaching to an existing ES with pre indexed docs. Can we add some documentation on how to do that as well, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some thoughts added on the st_state_patch.py
@Timoeller I went through your comments and added more information. |
Hey yes my bad. I saw these changes already briefly yesterday and was very happy about them. I did not find the time to properly check and approve the PR. Will do now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for adjusting the code.
About specifying EVAL_FILE=eval_labels_example.csv
we can worry later. Because if somebody specifies a custom file that file still needs to somehow get into the docker at build time like you did with COPY eval_labels_example.csv /home/user/
, correct?
Yes, that is true. Let's find a better way in the future |
Why not mounting the file into the container at runtime? We could add a volume in the docker-compose ... |
PR for issue #864