Rest API update with pipeline #927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… so basically we get rid of the finder in this page.
|
This issue can be closed since #922 tackled the subject at the same time 👍 and goes deeper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We update the rest API to make it compatible with the new "pipeline". I did this for two endpoints :
Why?
Get rid of the "finder" for these endpoints
What are limitations?
No limitations.
Breaking changes (Example of before vs. after)
The endpoints don't need model_id anylonger :
Issue related Refactor REST APIs to use the new Pipelines #649