Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch missing index in countReadsPerBin #574

Closed
dpryan79 opened this issue Aug 7, 2017 · 1 comment
Closed

Catch missing index in countReadsPerBin #574

dpryan79 opened this issue Aug 7, 2017 · 1 comment
Assignees
Labels

Comments

@dpryan79
Copy link
Collaborator

dpryan79 commented Aug 7, 2017

Sita pointed this out via email:

In deepTools-2.5.0.1-install/lib/python2.7/site-packages/deeptools/countReadsPerBin.py

240 for x in self.bamFilesList:
241 try:
242 y = bamHandler.openBam(x)
243 except Exception as err:
244 print err # this is missing
245 y = pyBigWig.open(x)

openBam will throw an exception if bam is missing index. But in your code you catch that and try to read it as bigwig. And then it fails with a mysterious error about opening a bam file with pybigwig.

Can we check for that?

That's definitely a mistake on my part.

@dpryan79 dpryan79 added the bug label Aug 7, 2017
@dpryan79 dpryan79 added this to the 2.6.0 milestone Aug 7, 2017
@dpryan79 dpryan79 self-assigned this Aug 7, 2017
dpryan79 added a commit that referenced this issue Aug 7, 2017
@dpryan79
Copy link
Collaborator Author

dpryan79 commented Aug 7, 2017

This is now fixed in the develop branch.

@dpryan79 dpryan79 closed this as completed Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant