Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-column tick labels in computeMatrix output? #614

Closed
dpryan79 opened this issue Oct 6, 2017 · 4 comments
Closed

Per-column tick labels in computeMatrix output? #614

dpryan79 opened this issue Oct 6, 2017 · 4 comments
Milestone

Comments

@dpryan79
Copy link
Collaborator

dpryan79 commented Oct 6, 2017

This is only relevant since the advent of computeMatrixOperations. Now that one can cbind different matrices, it's possible to have things like scale-regions and reference-point in the same plot. However, the ticks and labels are completely screwed up then. This is due to the whole matrix having a single set of labels/positions. An alternative to this would be to have a list of labels and positions that could repeat per-column. This would allow better mixing and matching of these. Implementing this might be a bit annoying due to backward compatibility, though if we make a new major release I'm not completely sold on having to care about that.

@vivekbhr
Copy link
Member

vivekbhr commented Oct 25, 2017

good point.. I haven't seen how bad it looks but might be a useful fix

@dpryan79
Copy link
Collaborator Author

dpryan79 commented Dec 8, 2017

Tested:

  • computeMatrix
    • scale-region
    • reference-point
  • computeMatrixOperations
    • cbind
    • subset
  • plotHeatmap
    • old format
      • normal
      • plotly
    • new format
      • normal
      • plotly
    • mixed scale-region/reference-point
      • normal
      • plotly
  • plotProfile
    • old format
      • normal
      • plotly
    • new format
      • normal
      • plotly
    • mixed scale-region/reference-point
      • normal
      • plotly
  • Tests updated to be correct (and all pass)
  • Document this under advanced features

@dpryan79
Copy link
Collaborator Author

I'm running into a but introduced in matplotlib-2.1.1 at the moment, it looks like we have to skip that release.

@dpryan79
Copy link
Collaborator Author

This is now merged into develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants