Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x and y limits for plotCorrelation scatter plot #709

Closed
dpryan79 opened this issue May 15, 2018 · 13 comments
Closed

x and y limits for plotCorrelation scatter plot #709

dpryan79 opened this issue May 15, 2018 · 13 comments
Assignees
Milestone

Comments

@dpryan79
Copy link
Collaborator

Instead of just a --maxRange, it'd be better to offer x and y axis limits.

@dpryan79
Copy link
Collaborator Author

This is now in develop.

@Xiaofei-git
Copy link

Could we set xRange and yRange at the same time? I will get an error if I want to set both of them as their own range.

$ plotCorrelation -in *.npz --corMethod pearson --skipZeros --xRange 0 2000 --yRange 0 2000 --plotTitle "Endosperm_Lai" --whatToPlot scatterplot -o *.png --outFileCorMatrix *.tab

Traceback (most recent call last):
File "**something/bin/plotCorrelation", line 12, in
main(args)
File "**something/Python/2.7.14/lib/python2.7/site-packages/deeptools/plotCorrelation.py", line 241, in main
log1p=args.log1p)
File "**something/Python/2.7.14/lib/python2.7/site-packages/deeptools/correlation.py", line 536, in plot_scatter
ax.set_ylim(min_yvalue, min(yRange, ax.get_ylim()[1]))
ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

@Xiaofei-git
Copy link

Also, do you think is it possible to plot based on the normalized read counts within a bin because every sample is different, e.g. library size?

@dpryan79
Copy link
Collaborator Author

I have a PR to fix the error you ran into. Regarding your second question, if you create normalized bigWig files (using RPGC in bamCoverage) and use those with multiBamSummary then the results will be properly normalized.

@Xiaofei-git
Copy link

I am sorry I did not follow you for the first answer. What do you mean by "PR"?

@dpryan79
Copy link
Collaborator Author

PR is short for a "pull request" on github. It's now been merged and will appear in the next release.

@Xiaofei-git
Copy link

So, that is mean for the current version 3.1.1, I can't set x-range and y-range differently, am I right? Thanks!

@Xiaofei-git
Copy link

I mean set them respectively.

@dpryan79
Copy link
Collaborator Author

Correct, that's a bug in the current version. I'll release 3.1.2 when I'm back in the office on Monday.

@Xiaofei-git
Copy link

Xiaofei-git commented Aug 17, 2018 via email

@Xiaofei-git
Copy link

For the normalization, you said " if you create normalized bigWig files (using RPGC in bamCoverage) and use those with multiBamSummary then the results will be properly normalized". But, after generating the bigWig files, how can I pass them to multiBamSummary because "multiBamSummary bins" take bam files not bw format?

@dpryan79
Copy link
Collaborator Author

Try multiBigwigSummary instead.

@Xiaofei-git
Copy link

Xiaofei-git commented Aug 21, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants