Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

computeGCBias - matplotlib axis limits error #969

Closed
giusem opened this issue Jul 10, 2020 · 3 comments
Closed

computeGCBias - matplotlib axis limits error #969

giusem opened this issue Jul 10, 2020 · 3 comments

Comments

@giusem
Copy link

giusem commented Jul 10, 2020

deeptools 3.4.3
python 3.7.6
matplotlib-base 3.2.2.

command:
computeGCBias -b ~/CLD_demo_project/CNV_visualization_test/03-mapping/cho_horizon_test_merged.bam -g ~/repository/cho_horizon_test/2bit/CHO_Horizon_test.2bit --effectiveGenomeSize 450000 -o cho_horizon_test_merged_gc_freq.tsv --biasPlot cho_horizon_test_merged_gc_freq.png

output:
filter_out: None
extra_sampling_file: None
genome_size: 456350
total_reads: 30552
reads_per_bp: 0.06789333333333333
max_reads: 99.0
min_reads: 0.0
computing frequencies
stepSize: 1
Traceback (most recent call last):
File "/u/gsemplic/miniconda3/envs/deeptools/bin/computeGCBias", line 12, in
main(args)
File "/u/gsemplic/miniconda3/envs/deeptools/lib/python3.7/site-packages/deeptools/computeGCBias.py", line 726, in main
plotGCbias(args.biasPlot, data, reads_per_gc, args.regionSize, image_format=args.plotFileFormat)
File "/u/gsemplic/miniconda3/envs/deeptools/lib/python3.7/site-packages/deeptools/computeGCBias.py", line 608, in plotGCbias
ax1.set_ylim(0 - (y_max * 0.05), y_max * 1.05)
File "/u/gsemplic/miniconda3/envs/deeptools/lib/python3.7/site-packages/matplotlib/axes/_base.py", line 3577, in set_ylim
bottom = self._validate_converted_limits(bottom, self.convert_yunits)
File "/u/gsemplic/miniconda3/envs/deeptools/lib/python3.7/site-packages/matplotlib/axes/_base.py", line 3101, in _validate_converted_limits
raise ValueError("Axis limits cannot be NaN or Inf")
ValueError: Axis limits cannot be NaN or Inf
(deeptools)

@LeilyR
Copy link
Contributor

LeilyR commented Jul 10, 2020

It is difficult for me to say what exactly caused that error message since I cannot reproduce it. But as the message says, it happens because y_max was either NaN or Inf, These values come from the whisker, so I wonder if you had some strange outlier that whisker returned Nan/Inf. Maybe you can check the output text file, if it has been generated. Other than that, I can add a parameter where you can specify the quantiles of your interest and see if that solve your problem.

dpryan79 pushed a commit that referenced this issue Jul 10, 2020
@giusem
Copy link
Author

giusem commented Jul 10, 2020 via email

@LeilyR
Copy link
Contributor

LeilyR commented Jul 10, 2020

Hi Giuseppe,
Nice to hear from you too ! I have already noticed that he had PR for that. Thanks for heads up! I am not going to touch the code. :)
Cheers,
Leily

LeilyR added a commit that referenced this issue Aug 10, 2020
* fix #969

* PEP8

* updated changes.txt

* fixed a little bug in parseCommon.py which caused flake8 failure.

* [WIP] added auto to plotheatmap #908 (#982)

* added auto to plotheatmap

* fixed lint, added warning message, updated the help for zmin, zmax

* galaxy test plotPCA

* lower down the delat for potPCA galaxy test

Co-authored-by: Leily Rabbani <rabbani@pc390.ie-freiburg.mpg.de>

* updated version and changes

* removed alpha from plotPCA test

* removed compare="sim_size"

Co-authored-by: Devon Ryan <devon.ryan@genedata.com>
Co-authored-by: Leily Rabbani <rabbani@pc390.ie-freiburg.mpg.de>
Co-authored-by: LeilyR <leila.rabbani@gmail.com>
@LeilyR LeilyR mentioned this issue Aug 21, 2020
@LeilyR LeilyR closed this as completed in 3bb56cc Aug 21, 2020
blaiseli pushed a commit to blaiseli/deepTools that referenced this issue Feb 17, 2021
* Fixes for 3.4.2

* disable azure on OSX

* Closes deeptools#945

* computeMatricOperation  dataRange (deeptools#951)

* Added dataRange to computeMatricOperation to return min,max,median and 10th and 90th percentile.

* fixed pep8

* more pep8 fix

* fixed test_sieve of azure tests

* one more fix for test_sieve

* imported pysam to test_readFiltering.py

* updated hash values for test_sieve

* fixed galaxy computeMatrixOperation.xml

* More fixes for galaxy wrapper

* fixed a little typo in bamCompare (deeptools#967)

* save the output matrix of the plotheatmap in a format to be compatible with running plotheatmap on it again (deeptools#968)

* Plot profile color map (deeptools#971)

* Now colors can be set by user for any heatmap in plotProfile. A bug in tick index for plotting heatmap is also fixed.

* added a small description

* pep8 fix

* added sortUsingSamples and clusterUsingSamples to the galaxy wrapper

* [WIP] added auto to plotheatmap deeptools#908 (deeptools#982)

* added auto to plotheatmap

* fixed lint, added warning message, updated the help for zmin, zmax

* galaxy test plotPCA

* lower down the delat for potPCA galaxy test

* fix deeptools#969 (deeptools#970)

* fix deeptools#969

* PEP8

* updated changes.txt

* fixed a little bug in parseCommon.py which caused flake8 failure.

* [WIP] added auto to plotheatmap deeptools#908 (deeptools#982)

* added auto to plotheatmap

* fixed lint, added warning message, updated the help for zmin, zmax

* galaxy test plotPCA

* lower down the delat for potPCA galaxy test

* updated version and changes

* removed alpha from plotPCA test

* removed compare="sim_size"

* fixed plotHeatmap.xml by removing size from the the params and adding anitizer for the 2 new params.

* upated change.txt

* updated the doc html

Co-authored-by: Devon Ryan <dpryan79@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants