Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add dns setup #767

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

docs: add dns setup #767

wants to merge 11 commits into from

Conversation

noahpb
Copy link
Contributor

@noahpb noahpb commented Sep 17, 2024

Description

Adding documentation on the DNS assumptions in UDS Core and added example for deploying in a non-dev environment.

Related Issue

Fixes #730

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@noahpb noahpb marked this pull request as ready for review September 17, 2024 18:31
@noahpb noahpb requested a review from a team as a code owner September 17, 2024 18:31
docs/deployment/dns.md Outdated Show resolved Hide resolved
docs/deployment/dns.md Outdated Show resolved Hide resolved
Comment on lines +64 to +66
{{% alert-note %}}
These service annotations and their values are subject to change. Please reference documentation from your cloud provider to ensure their validity.
{{% /alert-note %}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is the right place or necessary, but thoughts on adding a note about static IPs to reduce effects of LBs cycling? Maybe too cloud provider specific though...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great callout and a good best-practice. I'm not sure if we want to get into cloud-specific deployment best practices in this document though. Unless we disagree that most folks reading this documentation are aware of this behavior, I'm leaning towards keeping this out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just remove this callout altogether, it feels unnecessary the more I think about it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah might be fine to just delete this note - since it's just meant to be an example anyways?

Copy link
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall - few last comments.

Comment on lines +11 to +12
- *.<DOMAIN> / Tenant Gateway
- *.admin.<DOMAIN> / Admin Gateway
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-09-19 at 8 13 12 AM

These get clobbered on the docs site preview - could either escape the < and > characters, or just wrap in code backticks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! how did you render this out?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the docs repo, if you have hugo installed locally you can just run hugo serve. You will want to clone or copy core into the ./repo-docs folder first (I use a symlink locally for this), see the script we use to manage this: https://github.com/defenseunicorns/uds-docs/blob/main/scripts/integrated-docs.sh#L22

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to better integrate/task-ify this flow: #712

Comment on lines +64 to +66
{{% alert-note %}}
These service annotations and their values are subject to change. Please reference documentation from your cloud provider to ensure their validity.
{{% /alert-note %}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah might be fine to just delete this note - since it's just meant to be an example anyways?

istio-tenant-gateway tenant-ingressgateway LoadBalancer 10.43.47.182 k8s-istioten-tenant...elb.us-east-1.amazonaws.com 15021:31222/TCP,80:30456/TCP,443:32508/TCP 1h
```

From here, DNS records can be created for the environment. You can create A records that associate your top-level domain to the Public IP Addresses of your Load Balancers. For subdomains, CNAME records can be used. For more information on how to configure DNS in AWS, see this [documentation](https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/routing-to-elb-load-balancer.html).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For more information on how to configure DNS in AWS, see this documentation.

I think we can leave it if you think it would be valuable, but want to be careful about giving the impression that this only works/has been tested with AWS. Unfortunately I think most docs we could link would be provider specific (i.e. Route53, Cloudflare, ...). Maybe sufficient to just drop the last line and reference "refer to your DNS provider's documentation"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document DNS assumptions/setup for Istio gateways
2 participants