-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: modify create_output_panel output to match object returned #950
fix: modify create_output_panel output to match object returned #950
Conversation
A similar fix is present here https://github.com/deforum-art/sd-forge-deforum/blob/main/scripts/deforum_helpers/ui_right.py#L99-L105 |
Confirmed that this fixed the issue locally for me. Thanks |
This only partially works on my computer. Clicking on the Generate button does nothing. 🤷🏻♂️ But, as soon as I added a new
I am on A1111 1.8.0
|
@viking1304 What lines do you add the |
@walteryoung I am not sure I understood your question correctly. If it was about what my code was based on, then this A1111 commit |
@jarrodpan please merge my pull request for buttons |
Thanks for this, I can confirm i had the same issue and your changes work, i'll merge them into this PR. |
Make buttons clickable
merge main into fix PR
Thanks! I had fixed this for Forge in https://github.com/deforum-art/sd-forge-deforum but didn't realise it also applied to recent a1111 versions. |
Are you sure object_panel has
|
@kylewetton you need to update a1111 to 1.8.0 and then to update deforum, and everyting should work |
So, we ready to release this onto the world? People need... :-) |
Ah it's been merged. I'm obviously having a bad hair day! |
Ever since this commit AUTOMATIC1111/stable-diffusion-webui@501993e#diff-7825c63da20059aa9e36a44157ab1a6b36a02bd71c01f5f30ea5d028320ef263R240
the signature of
create_output_panel
has been a class object which can not be iterated, howeverui_right.py
expects an iterable.This PR fixes the issue in a similar style to https://github.com/hako-mikan/sd-webui-supermerger/pull/323/files
fixes #949 #948 #934